feat: remove addmission webhooks

address #99 BREAKING CHANGE: - remove admission webhooks from default YAML installation - remove '--disable-admission-webhook'and '--admission-webhook-addr' from brain
cnrancher · Jun 15, 2020 · 519e33e · 519e33e
1 parent 36f5a7a
commit 519e33e
Show file tree

Hide file tree

Showing 17 changed files with 3 additions and 1,224 deletions.
diff --git a/api/v1alpha1/devicelink_webhook.go b/api/v1alpha1/devicelink_webhook.go
diff --git a/cmd/brain/options/config.go b/cmd/brain/options/config.go
@@ -5,16 +5,12 @@ import (
 )
 
 type Options struct {
-	AdmissionWebhookAddr    int
-	DisableAdmissionWebhook bool
-	MetricsAddr             int
-	EnableLeaderElection    bool
+	MetricsAddr          int
+	EnableLeaderElection bool
 }
 
 func (in *Options) Flags(fsName string) (nfs cliflag.NamedFlagSets) {
 	fs := nfs.FlagSet(fsName)
-	fs.IntVar(&in.AdmissionWebhookAddr, "admission-webhook-addr", in.AdmissionWebhookAddr, "The port is used for serving admission server.")
-	fs.BoolVar(&in.DisableAdmissionWebhook, "disable-admission-webhook", in.DisableAdmissionWebhook, "Disable admission webhook for controller.")
 	fs.IntVar(&in.MetricsAddr, "metrics-addr", in.MetricsAddr, "The port is used for serving prometheus metrics")
 	fs.BoolVar(&in.EnableLeaderElection, "enable-leader-election", in.EnableLeaderElection, "Enable leader election for controller. Enabling this will ensure there is only one active controller manager.")
 	return

diff --git a/deploy/e2e/all_in_one.yaml b/deploy/e2e/all_in_one.yaml
@@ -534,7 +534,6 @@ spec:
       - args:
         - brain
         - --enable-leader-election
-        - --disable-admission-webhook
         image: cnrancher/octopus:master
         imagePullPolicy: Always
         name: octopus