Onboard Kube State Metrics onto CLOMonitor #1380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan Escalada <[email protected]>
Signed-off-by: Juan Escalada <[email protected]>
14 tasks
mrueg
reviewed
Dec 15, 2023
mrueg
reviewed
Dec 15, 2023
mrueg
reviewed
Dec 15, 2023
|
Thanks for your contribution! I added a couple of questions, from a project side the rest looks good to me. Edit:Looks good to me. |
Signed-off-by: Juan Escalada <[email protected]>
mrueg
approved these changes
Dec 15, 2023
rexagod
reviewed
Dec 16, 2023
| description: Add-on agent to generate and expose cluster-level metrics. | ||
| category: observability | ||
| logo_url: https://raw.githubusercontent.com/cncf/artwork/master/projects/kubernetes/icon/color/kubernetes-icon-color.svg | ||
| devstats_url: https://k8s.devstats.cncf.io/ |
There was a problem hiding this comment.
This should take folks directly to the KSM dashboard.
Suggested change
| devstats_url: https://k8s.devstats.cncf.io/ | |
| devstats_url: https://k8s.devstats.cncf.io/d/49/github-stats-by-repository?orgId=1&var-period=h24&var-repos=%22kubernetes%2Fkube-state-metrics%22&var-stat=reviewers |
There was a problem hiding this comment.
(I'm assuming here that the dashboard links are not prone to change and stable, feel free to ignore this if that's not the case)
|
Thanks @jescalada! Kube State Metrics has been added to CLOMonitor as part of #1385. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for Kubernetes Security Slam, Task 7:
The following issue contains all the related tasks:
kubernetes/kube-state-metrics#2274
Feel free to make any changes as required!