removes ccnl_addr2ascii calls in DEBUGMSG macros containing NULL #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had to remove |
This commit remove calls to ccnl_addr2ascii which are passed to the
DEBUGMSG macro and could have "NULL" as a parameter, e.g.
DEBUGMSG_CFWD(INFO, " incoming interest=<%s>%s nonce=%"PRIi32" from=%s\n",
ccnl_prefix_to_str((*pkt)->pfx,s,CCNL_MAX_PREFIX_SIZE),
ccnl_suite2str((*pkt)->suite), nonce,
ccnl_addr2ascii(from ? &from->peer : NULL));
blacksheeep
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses (partially) #232 and removes
ccnl_addr2asciicalls inccnl-fwd.cwhich might have NULL as a parameter as a result of the evaluation of an ternary operator, i.e.In order to test this PR, the
USE_LOGGINGflag needs to be set. In addition, logging needs to be enabled in theccn-lite-relayexample by settingdebug_level = VERBOSE;.