Skip to content
This repository was archived by the owner on Jun 6, 2024. It is now read-only.

feat: introduce sqlite data store #43

Merged
merged 16 commits into from
Apr 29, 2024
Merged

feat: introduce sqlite data store #43

merged 16 commits into from
Apr 29, 2024

Conversation

xx01cyx
Copy link
Member

@xx01cyx xx01cyx commented Apr 19, 2024

solves #24

@xx01cyx xx01cyx changed the title feat: implement sqlite data store feat: introduce sqlite data store Apr 20, 2024
@xx01cyx xx01cyx marked this pull request as ready for review April 27, 2024 21:54
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 91.95804% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 87.84%. Comparing base (64604a8) to head (b6d96d9).
Report is 4 commits behind head on main.

Files Patch % Lines
...rage-node/src/cache/data_store_cache/sqlite/mod.rs 88.81% 6 Missing and 12 partials ⚠️
storage-node/src/error.rs 0.00% 3 Missing ⚠️
...age-node/src/cache/data_store_cache/sqlite/blob.rs 98.36% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   88.80%   87.84%   -0.96%     
==========================================
  Files          17       20       +3     
  Lines        2170     2543     +373     
  Branches     2170     2543     +373     
==========================================
+ Hits         1927     2234     +307     
- Misses        130      182      +52     
- Partials      113      127      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xx01cyx xx01cyx requested review from lanlou1554 and unw9527 April 27, 2024 22:30
Copy link
Collaborator

@lanlou1554 lanlou1554 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xx01cyx xx01cyx merged commit 55aee53 into main Apr 29, 2024
1 check passed
@unw9527 unw9527 deleted the yx/sqlite branch April 30, 2024 00:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants