Add support for adding variable-size attributes (std::vector) within objects for NanoAOD #46702
+612
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Add support for adding variable-size attributes (std::vector) within objects for NanoAOD. Presented at XPOG meeting on 13.11.2024. In addition, after the presentation, lazy evaluation functionality has been added.
Tested mainly in context of ScoutingNano, but this functionality is generic and can be useful for any custom NanoAOD. Hence, we decided to make this PR with only variable-size attributes support in NanoAOD. For usage in ScoutingNano, we will prepare another PR later after discussion with scouting group.
PR validation:
Tested with ScoutingNano (for ScoutingMuon and ScoutingElectron) with workflow 2500.227(RelValTTbar/2024/MINIAODSIM) and 2500.237 (ScoutingPFRun3/2024D/HLTSCOUT) as presented in the slide.
For lazy evaluation, test with workflow 2500.237 by setting ScoutingMuon's hitPattern variable with
lazyEval=True
. The output step2.root looks the same as output step2.root when settinglazyEval=False
.Pass all tests when running:
scram b runtests use-ibeos
When running
runTheMatrix.py -l limited -i all --ibeos
, some workflows failed due to file open errors. Tested 3 times and got the similar file open errors.Failed workflows are:
312.0
25202.0, 14234.0, 250202.181
which are all due to file open errors.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is not a backport and there is no plan for a backport.