Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing Cluster Splitting with HLT Vertices #46694

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AdrianoDee
Copy link
Contributor

@AdrianoDee AdrianoDee commented Nov 13, 2024

PR description:

This PR proposes the introduction of a new process modifier hltClusterSplitting that:

  • enables to write the hltPixelVertices in FEVTDEBUGHLTEventContent;
    • one could test also just the hltTrimmedPixelVertices that are just 1-2 for Run3 HLT;
  • uses those vertices for the ak4CaloJetsForTrkPreSplitting and the cluster splitter;
    • these producers actually use only the coordinates so the content to be stored could be actually slimmed down to be just a collection of floats;
  • removes the InitialStepPreSplitting iteration from iterative tracking.

Running on 14_2_0_pre2 RelVals with Run3 PU:

the tracking performance seems untouched.

Screenshot 2024-11-13 alle 16 58 14

I don't know how much this would be useful for Run3, but it may be interesting to check it for Phase2. For Run3 I've measured (roughly) a speedup of 1.5-2% on a TTbar Run3 PU 2025 conditions sample.

I took the chance also to add a specific wf with offset .19003 (to be aligned to the other cluster splitting related wfs) and a ProdLike version with .1900321.

PR validation:

runTheMatrix.py -w upgrade -l 17434.19003,17434.1900321

@AdrianoDee
Copy link
Contributor Author

type tracking

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 13, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46694/42636

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • Configuration/EventContent (operations)
  • Configuration/ProcessModifiers (operations)
  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • RecoTracker/IterativeTracking (reconstruction)
  • Validation/RecoTrack (dqm)

@AdrianoDee, @Moanwar, @antoniovagnerini, @antoniovilela, @cmsbuild, @davidlange6, @DickyChant, @fabiocos, @jfernan2, @mandrenguyen, @miquork, @rappoccio, @rseidita, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @fabiocos, @felicepantaleo, @gpetruc, @makortel, @missirol, @mmusich, @mtosi, @rovere, @slomeo, @wmtford this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Contributor Author

test parameters:

  • relval_opts = -w upgrade
  • workflow = 17434.19003

@AdrianoDee
Copy link
Contributor Author

please test

def setup_(self, step, stepName, stepDict, k, properties):
stepDict[stepName][k] = merge([{'--procModifiers': 'hltClusterSplitting'}, stepDict[step][k]])
# if step in ["Digi","HLTOnly","DigiTrigger"]:
# stepDict[stepName][k] = merge([{'--customise': 'RecoLocalTracker/SubCollectionProducers/customizeSplittingFromHLT.customiseSplittingFromHLT'}, stepDict[stepName][k]])
Copy link
Contributor Author

@AdrianoDee AdrianoDee Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to remove these comments.


hltClusterSplitting.toModify(siPixelClusters,
vertices = cms.InputTag("hltPixelVertices")
# hltPoint = cms.InputTag("hltTrimmedPixelVertices"),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also these, will do a cleanup after the tests.

@cmsbuild cmsbuild mentioned this pull request Nov 13, 2024
3 tasks
@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 60KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae3468/42814/summary.html
COMMIT: 675550f
CMSSW: CMSSW_14_2_X_2024-11-13-1300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46694/42814/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 282 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3450336
  • DQMHistoTests: Total failures: 2307
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3448009
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 206 log files, 177 edm output root files, 47 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants