MTD geometry: update MTDGeometry test, use only DD4hep backend, add ETL pixel position test

[fabiocos]

PR description:

Complete revision of the (unit) test suite for Geometry/MTDGeometryBuilder:

• MTDDigiGeometryAnalyzer simplified, no full dump of geometry;
• DD4hep_TestBTLPixelTopology moved to DD4hep_TestPixelTopology, full comparison of ideal and reco geometries for both BTL and ETL, with dump of position of ETL reference pixel (needed to test the development of ETL v9).

Only the DD4hep version of the test is now run, since MTDGeometry is independent on the backend, provided the MTDNumberingBuilder output is the same.

The filtering of volumes has been optimized to prevent the navigation of the full volume tree.

PR validation:

The code runs for scenario D110, providing the expected output. The reference needs to be updated in the cms-data area to have a successful completion of the unit test.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46683/42617

[cmsbuild]

A new Pull Request was created by @fabiocos for master.

It involves the following packages:

• Geometry/MTDGeometryBuilder (upgrade, geometry)

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@bsunanda, @martinamalberti this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test with cms-data/Geometry-TestReference#16

[cmsbuild]

-1

Failed Tests: UnitTests
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b4aac/42774/summary.html
COMMIT: db2346d
CMSSW: CMSSW_14_2_X_2024-11-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46683/42774/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @perrotta Update a few GTs in autoCond #46671
• @aloeliger Sort Phase 2 L1T GT trigger paths #46303
• @CMS-LUMI-POG pileup profile 2025_LHC_Simulation_fill12p5h_levelling9h_nb2340_xSec80mb_il2p23 #46557
• @bsunanda Run3hcx378A Provide a way to avoid Digitization for the ZDC detector #46570

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b4aac/42774/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b4aac/42774/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMGUIUpload had ERRORS

Comparison Summary

There are some workflows for which there are errors in the baseline:
2024.101001 step 1
2024.202001 step 1
2024.303001 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially added 14 lines to the logs
• Reco comparison results: 2610 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3070351
• DQMHistoTests: Total failures: 2270
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3068061
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
• Checked 190 log files, 160 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[fabiocos]

Failures appear unrelated to this PR

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46683/42622

[cmsbuild]

Pull request #46683 was updated. @Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please check and sign again.

[fabiocos]

please test with cms-data/Geometry-TestReference#16

[cmsbuild]

-1

Failed Tests: UnitTests
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b4aac/42778/summary.html
COMMIT: a07ea53
CMSSW: CMSSW_14_2_X_2024-11-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46683/42778/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @perrotta Update a few GTs in autoCond #46671
• @aloeliger Sort Phase 2 L1T GT trigger paths #46303
• @CMS-LUMI-POG pileup profile 2025_LHC_Simulation_fill12p5h_levelling9h_nb2340_xSec80mb_il2p23 #46557
• @bsunanda Run3hcx378A Provide a way to avoid Digitization for the ZDC detector #46570

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b4aac/42778/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b4aac/42778/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMGUIUpload had ERRORS

Comparison Summary

There are some workflows for which there are errors in the baseline:
2024.101001 step 1
2024.202001 step 1
2024.303001 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially added 14 lines to the logs
• Reco comparison results: 2616 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3070351
• DQMHistoTests: Total failures: 2285
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3068046
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
• Checked 190 log files, 160 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[fabiocos]

@cms-sw/geometry-l2 @cms-sw/upgrade-l2 the errors have nothing to do with this PR, any comment?

[Moanwar]

+Upgrade