Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BTV,DQM] Expand MiniAOD input DQM and Validations plots with latest taggers, switch to slimmedJetsPuppi #46674

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[BTV,DQM] Expand MiniAOD input DQM and Validations plots with latest taggers, switch to slimmedJetsPuppi #46674

wants to merge 5 commits into from
+406 −248

Conversation

nurfikri89
Copy link
Contributor

PR description:

This PR expands the BTV DQM & Validation plots by adding ParticleNet and UParT taggers that are stored in MiniAOD. The jet collection has changed to AK4 Puppi jets (slimmedJetsPuppi). The working point cut values updated to Summer23BPix campaign. Removed a few files and consolidated their contents into a single file.

PR validation:

  • passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos with the exception of a few workflows which failed because of missing relval input files.
  • passes MiniAOD workflows: runTheMatrix.py -i all --ibeos -l 2500.021,2500.022,2500.023,2500.024,2500.031,2500.032,2500.033,2500.034

@cmsbuild cmsbuild added this to the CMSSW_14_2_X milestone Nov 12, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 12, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46674/42596

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nurfikri89 for master.

It involves the following packages:

  • DQMOffline/RecoB (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @andrzejnovak, @castaned, @rociovilar this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@antoniovagnerini
Copy link

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcdb6a/42759/summary.html
COMMIT: 046c953
CMSSW: CMSSW_14_2_X_2024-11-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46674/42759/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMGUIUpload had ERRORS

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3450336
  • DQMHistoTests: Total failures: 8582
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3441734
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 59281.600999999995 KiB( 46 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 0.624 KiB Btag/ParticleNetCentral_TauVsEle_ETA_1v4-2v5
  • DQMHistoSizes: changed ( 1000.0 ): 0.624 KiB Btag/ParticleNetCentral_TauVsJet_ETA_1v4-2v5
  • DQMHistoSizes: changed ( 1000.0 ): 0.620 KiB Btag/ParticleNetCentral_TauVsMu_ETA_1v4-2v5
  • DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_BvsAll_ETA_1v4-2v5
  • DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_TauVsEle_ETA_0-1v4
  • DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_TauVsJet_ETA_0-1v4
  • DQMHistoSizes: changed ( 1000.0 ): 0.612 KiB Btag/ParticleNetCentral_TauVsMu_ETA_0-1v4
  • DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_BvsAll_ETA_0-1v4
  • DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_CvsB_ETA_1v4-2v5
  • DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_CvsL_ETA_1v4-2v5
  • DQMHistoSizes: changed ( 1000.0 ): ...
  • Checked 206 log files, 177 edm output root files, 47 DQM output files
  • TriggerResults: no differences found

@nurfikri89
Copy link
Contributor Author

Unit test fail due to this #46682?

@antoniovagnerini
Copy link

please test

@antoniovagnerini
Copy link

Unit test fail due to this #46682?

yes but it should be fixed now

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcdb6a/42834/summary.html
COMMIT: 046c953
CMSSW: CMSSW_14_2_X_2024-11-13-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46674/42834/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test TestDQMServicesDemo had ERRORS
---> test TestDQMGUIUpload had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 284 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3450524
  • DQMHistoTests: Total failures: 10440
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3440064
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 59281.600999999995 KiB( 46 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 0.624 KiB Btag/ParticleNetCentral_TauVsEle_ETA_1v4-2v5
  • DQMHistoSizes: changed ( 1000.0 ): 0.624 KiB Btag/ParticleNetCentral_TauVsJet_ETA_1v4-2v5
  • DQMHistoSizes: changed ( 1000.0 ): 0.620 KiB Btag/ParticleNetCentral_TauVsMu_ETA_1v4-2v5
  • DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_BvsAll_ETA_1v4-2v5
  • DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_TauVsEle_ETA_0-1v4
  • DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_TauVsJet_ETA_0-1v4
  • DQMHistoSizes: changed ( 1000.0 ): 0.612 KiB Btag/ParticleNetCentral_TauVsMu_ETA_0-1v4
  • DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_BvsAll_ETA_0-1v4
  • DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_CvsB_ETA_1v4-2v5
  • DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_CvsL_ETA_1v4-2v5
  • DQMHistoSizes: changed ( 1000.0 ): ...
  • Checked 206 log files, 177 edm output root files, 47 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcdb6a/42850/summary.html
COMMIT: 046c953
CMSSW: CMSSW_14_2_X_2024-11-13-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46674/42850/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMGUIUpload had ERRORS

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3450524
  • DQMHistoTests: Total failures: 8538
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3441966
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 59281.600999999995 KiB( 46 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 0.624 KiB Btag/ParticleNetCentral_TauVsEle_ETA_1v4-2v5
  • DQMHistoSizes: changed ( 1000.0 ): 0.624 KiB Btag/ParticleNetCentral_TauVsJet_ETA_1v4-2v5
  • DQMHistoSizes: changed ( 1000.0 ): 0.620 KiB Btag/ParticleNetCentral_TauVsMu_ETA_1v4-2v5
  • DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_BvsAll_ETA_1v4-2v5
  • DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_TauVsEle_ETA_0-1v4
  • DQMHistoSizes: changed ( 1000.0 ): 0.616 KiB Btag/ParticleNetCentral_TauVsJet_ETA_0-1v4
  • DQMHistoSizes: changed ( 1000.0 ): 0.612 KiB Btag/ParticleNetCentral_TauVsMu_ETA_0-1v4
  • DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_BvsAll_ETA_0-1v4
  • DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_CvsB_ETA_1v4-2v5
  • DQMHistoSizes: changed ( 1000.0 ): 0.608 KiB Btag/ParticleNetCentral_CvsL_ETA_1v4-2v5
  • DQMHistoSizes: changed ( 1000.0 ): ...
  • Checked 206 log files, 177 edm output root files, 47 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved dqm-pending orp-pending pending-signatures tests-rejected tracking
Projects
None yet
Milestone
CMSSW_14_2_X
Development

Successfully merging this pull request may close these issues.
4 participants
@nurfikri89 @cmsbuild @antoniovagnerini @smuzaffar