Skip to content

Merge RunNanoDST into master? #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Merge RunNanoDST into master? #7

wants to merge 11 commits into from

Conversation

abrinke1
Copy link
Contributor

@wang-hui , @zhenbinwu
Can you take a look at this PR and see whether all the changes from the "RunNanoDST" branch should go into "master"?

Zhenbin Wu added 11 commits July 27, 2017 19:12
There are two paths stored in the NanoDST PD.
1. The 1.5kHz L1_Zerobias from the L1. One can use them for the L1Menu
rate estimation. Just run on the NanoDST as the default Zerobias dataset.

2. The L1Accept, with HLT prescaled. This stored all the event fired L1,
  with a certain HLT prescale. To run over them, you need to input the
  SetL1AcceptPS as the HLT prescale of this run. The code will disable
  the Zerobias counting and use nLumi as counting. Also the prescale is
  applied during the run. So the input prescale should consider relative
  prescale.

  For testing, you can start with the below option, which should reproduce
  the online L1Rate, assume L1AcceptPS is 10:
  --UseUnpackTree --nBunches -1 --SetL1AcceptPS 10 --SetNoPrescale

  This procedure should be tested and further understood. Given the above
  description, it is probabaly not the best option for the L1Menu rate
  estimation.
Ops, fixed a logic mistake
@tempse
Copy link
Member

tempse commented Jun 25, 2019

Hi @zhenbinwu , @wang-hui , all,
How should we proceed with this PR? Before starting to restructure the repository, we need to resolve this one.
Thanks a lot!

@zhenbinwu
Copy link
Collaborator

@wang-hui It seems most of the conflict is from your merging your branch to master. Can you cherry-pick the changes in my branch into yours? I think this was my quick fix to run over NanoDST sample. It is quite minor changes I think. Thanks!

@zhenbinwu
Copy link
Collaborator

@tempse I don't think this should be a show stopper, since we barely need to run over NanoDST anyway.

@abrinke1
Copy link
Contributor Author

Hi @zhenbinwu , @tempse ,
I don't know the inner workings of this code, but I certainly think we should not loose the ability to run over NanoAOD. It's not critical now, but will be useful again in Run 3, when most of us are now longer around doing menu studies.
Best, Andrew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants