Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Spell mods on player reconnect #576

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Novivy
Copy link

@Novivy Novivy commented Aug 3, 2024

🍰 Pullrequest

This fix a very old bug where the client would not apply spell modifiers like talents when a player is reconnecting while having its character still connected in-game.

Proof

  • None

Issues

  • None

How2Test

  • Login on a warlock character.
  • Take the improved 5/5 corruption talent which makes corruption spell instant cast.
  • .save
  • Open another client, connect on same character while having the character still in-game on the first client
  • Try to cast corruption while moving.

Without this fix, you won't be able to cast it while moving, despite having the 5/5 talent.

@Novivy
Copy link
Author

Novivy commented Aug 3, 2024

Another related issue to this particular situation: If you are on a fly path when reconnecting, you will drop to the ground.

On my end I fixed it by kicking the player before resetting the session state ( if (!m_session->RequestNewSocket(this))) if is he is on a flypath as I don't have much time to find the root cause right now.

@killerwife
Copy link
Contributor

Please, each PR needs to be its own branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants