Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed a check to see if the destination is smaller than the source. Th... #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jllamas
Copy link

@jllamas jllamas commented Apr 10, 2012

...e gem should just resize the image to whenever it is handed.

… The gem should just resize the image to whenever it is handed.
@jllamas
Copy link
Author

jllamas commented Apr 10, 2012

I tested this gem update with unicron local to my box.

My test set of images now properly do all the following actions:

Image source larger than copy => Creates image
Image source same size as copy => Creates image
Image source smaller than copy => Creates image

I could not run the gem's tests as it attempts to build the gem on the fly and it fails on my mac since I can't pass the compile headers I need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant