Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added escaping for: for to adapt windows path #67

Closed
wants to merge 1 commit into from

Conversation

lllbbbyyy
Copy link

@lllbbbyyy lllbbbyyy commented Oct 10, 2022

Description

On Windows platforms, colons are used in paths as part of the drive letter, which can cause incorrect parsing as command arguments. Escaped colons (\:) are handled here so that they can be properly escaped

Motivation and Context

Adaptation changes made for Windows platform support for kitex

Related Issue

fix cloudwego/kitex#469

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@HeyJavaBean
Copy link
Member

hi,感谢提议。但现在我们暂时还没考虑支持 windows 场景。等后续开始适配 windows 了我们再系统性的做支持。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[GLCC 赛题] 为 kitex 适配 Windows
3 participants