refactor: stream api #1658
Open
refactor: stream api #1658
+2,813
−4,282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YangruiEmma
reviewed
Feb 5, 2025
client/client.go
Outdated
| sxStreamMW streamx.StreamMiddleware | ||
| sxStreamRecvMW streamx.StreamRecvMiddleware | ||
| sxStreamSendMW streamx.StreamSendMiddleware | ||
| eps cep.UnaryEndpoint |
There was a problem hiding this comment.
这个怎么和原来的 endpoint.Endpoint 兼容
YangruiEmma
reviewed
Feb 5, 2025
DMwangnima
reviewed
Feb 5, 2025
internal/client/option.go
Outdated
|
|
||
| type StreamOptions struct { | ||
| EventHandler stream.StreamEventHandler | ||
| RecvTimeout time.Duration |
There was a problem hiding this comment.
Recv/Send 都暴露了 ctx 参数，到底是使用 ctx 里的 deadline 还是这里的配置得斟酌下
client/client.go
Outdated
| kc.eps = mwchain(innerHandlerEp) | ||
| eps := mwchain(innerHandlerEp) | ||
|
|
||
| kc.eps = cep.UnaryChain(kc.opt.UnaryOptions.UnaryMiddlewares...)(func(ctx context.Context, req, resp interface{}) (err error) { |
There was a problem hiding this comment.
对于 Ping-Pong 调用，我们期望的是WithMiddleware被WithUnaryMiddleware 取代？
那么中间件的执行顺序也应该保持一致吧，我理解按照这里的拼装方式，UnaryMiddleware 先执行了
jayantxie
force-pushed
the
refactor/streamx-api
branch
6 times, most recently
from
916a7a6 to
0693120
Compare
jayantxie
force-pushed
the
refactor/streamx-api
branch
2 times, most recently
from
4b98864 to
91effeb
Compare
jayantxie
force-pushed
the
refactor/streamx-api
branch
from
91effeb to
326f232
Compare
jayantxie
force-pushed
the
refactor/streamx-api
branch
from
7c0df80 to
58976c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
refactor
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: