-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alb example that showcases autoscaling groups and route53 a aliases #656
base: main
Are you sure you want to change the base?
Conversation
@hmain there was an issue with a newer version of pycodestyle that I just fixed. Please re-push your changes to get another travis run with your changes. Note: you do need to add the json output into tests/examples_output in order for it to pass. Try running |
@markpeek Thank you for your guidance, one test is failing at the moment for python 2.7, which is much better than before. |
Ok, seems like the test is failing because of: Which shouldn't fail. I'm not sure how to add a new test which validates this correctly, so any help here would be awesome. |
I've had another look into troposphere/troposphere/autoscaling.py and it seems like it supports my attribute there so I am not sure why it complains. Feel free to point me where it could be and I'll have a look at changing the behavior. |
@hmain thank you for bringing up this PR again. I looked at it a little today and need more time to look further. I think there are some issues with how the template generator is functioning (might not like certain types of imports and might not deal with nested functions) along with a fundamental issue with how lists of objects is handled (the Conditions should be a list but it isn't getting flagged as an error). For example, the use of "import troposphere.autoscaling as autoscaling" seems to cause the above error but "from troposphere import autoscaling" looks to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please merge this
The examples are extremely useful so I thought I'd give back and create one of my own that showcases:
If it's too much in one template, or if it's not up to standards, or something else is wrong; please feel free to tell me so as this is my first pull-request in this project.