feat: Support chunks in resource resolvers #2287
Open
+92
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
changed the title
erezrokah
force-pushed
the
feat/list_details_arrays
branch
from
729634a to
105f97e
Compare
bbernays
reviewed
Nov 4, 2025
| type RowResolver func(ctx context.Context, meta ClientMeta, resource *Resource) error | ||
|
|
||
| type RowsChunkResolver struct { | ||
| ChunkSize int |
There was a problem hiding this comment.
I think we need a way of ensuring ChunkSize is always less than 100 as that is what BatchSender uses
There was a problem hiding this comment.
Or make BatchSender batch limit configurable
bbernays
reviewed
Nov 4, 2025
|
Looks legit; I didn't have @bbernays context so I would have approved it. Let's wait for that and LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes cloudquery/cloudquery#14601
Still untested, opening for referenceTested this in https://github.com/cloudquery/cloudquery-private/pull/9520 (internal link)
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)