Support multiple EBS volume types & set default to less-expensive gp3

[mbijon]

This is a minor change that could offer a very small cost-savings for bastion hosts. We would like to see it reflected upstream if possible.

If the change to a gp3 default is concerning due to a large volume of TF updates, could the support for specifying volume_type still be added so we can manually specify gp3?

NOTE: This change overlaps partly with #72.

1. That PR absorbed some other work that wasn't ready for upstream b/c we based it on master
2. This change responds to the PR comment: Changes root volume default-type to gp3 #72 (comment)

what

• Changes the root volume of the bastion instances from gp2 to the newer gp3 type
• Still allows support for gp2, standard or any other volume types
• Adds validation to volume-type var. All TF 0.13+ types are included: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/instance#volume_type

why

• The gp3 type now being set as default is both less expensive per-GB and more-performant for small volumes
  • Since bastion servers have small boot volumes they should never need the larger-sizes where gp2 is needed
  • This is mainly a cost-savings for bastion disk-patterns
• Allowing volume-type to be specified allows gp2 or standard volume-types if required

references

• https://aws.amazon.com/about-aws/whats-new/2020/12/introducing-new-amazon-ebs-general-purpose-volumes-gp3/

[bridgecrew]

Bridgecrew has found 1 infrastructure configuration error in this PR ⬇️

[mbijon]

I think the "Auto Format" workflow failure is due to a configuration error or traffic-issue for your "cloudpossebot" @Gowiem. The repo it's getting a 403 from is publicly accessible: https://github.com/WorkingGroupLink/terraform-aws-ec2-bastion-server/

remote: Permission to WorkingGroupLink/terraform-aws-ec2-bastion-server.git denied to cloudpossebot.
fatal: unable to access 'https://github.com/WorkingGroupLink/terraform-aws-ec2-bastion-server/': The requested URL returned error: 403
Error: Process completed with exit code 128.

[Gowiem]

@mbijon happens sometimes. Mind pushing an empty commit? It will sometimes resolve itself --

git commit --allow-empty -m "Trigger CI"
git push

Thanks!

[Gowiem]

/test all

This Pull Request has been updated, so we're dismissing all reviews.

[mbijon]

Done @Gowiem. Unfortunately it also triggered a merge-commit on my end & failed again anyway...

@mbijon happens sometimes. Mind pushing an empty commit? It will sometimes resolve itself --

git commit --allow-empty -m "Trigger CI"
git push

Thanks!

[Gowiem]

Ah @mbijon I think with you opening from another org ("WorkingGroupLink"), it's not getting the proper permissions... I'm not sure what the deal is there. @Nuru can I bug you to shed some knowledge on how this works when you have a minute? I know I've seen you poke people for this before.

[mbijon]

@Gowiem wouldn't it work better, faster if you cherry-picked my code into a local branch?

If so, I pushed a cleaner branch without the merge commits to here. Just grab the 2 most-recent commit for the work that matters: https://github.com/WorkingGroupLink/terraform-aws-ec2-bastion-server/commits/mbijon/volume-type

[bmbferreira]

👋 I'm interested in this as well. Can this be merged any time soon please? Thanks for all the great work 🙇

[hans-d]

/terratest

[mergify]

Thanks @mbijon for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.