Update README.md #308
Merged
Update README.md #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `name` field to second example. There is a known bug cloudposse#151 if the name field is ommited. Might be easier to just update the docs than fix the bug, since it's been open since 2021.
|
These changes were released in v0.95.0. |
|
Done. |
Gowiem
added
documentation
|
/terratest |
|
Any update on this PR? Anything required from my end? |
|
/terratest |
gberenice
approved these changes
May 28, 2024
There was a problem hiding this comment.
@keithrozario this will be automerged when the checks are passed. Thanks!
|
Thank you 😃 !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated README.MD
what
Added
namefield to second example. There is a known issue #151 if the name field is omitted. Might be easier to just update the docs than fix the bug, since it's been open since 2021.why
The issue throws an non-descriptive error "Error: origin.0.origin_id must not be empty," which doesn't help users troubleshoot. It has also been open since 2021, which suggest it probably isn't a "bug" anymore. Best to just update the docs to save people time.
references
closes #151