Log service plan visibility on create or update service instances #4230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svkrieger
reviewed
Mar 4, 2025
|
|
||
| def service_plan_not_visible_to_user!(service_plan) | ||
| user = VCAP::CloudController::SecurityContext.current_user | ||
| logger.info("Service Plan with guid '#{service_plan.guid}' and id '#{service_plan.id}' is not visible in current org to user with guid '#{user.guid}'.") |
There was a problem hiding this comment.
'in current org' is not correct here as the user can see the plan if he has access to it in any org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement of #4230.
For case 1 and 2 a log info is additionally added to have it easier to find the root cause when users get 422 CF-UnprocessableEntity error. Due to security reasons, this is just added as log info and not as error message.
An explanation of the use cases your change solves
Make it easier to find the root cause when users get 422 CF-UnprocessableEntity error
Links to any other associated PRs
Better error message and support logs for /v3/service_offerings and plans #4213
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests