This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
Optional enable_drain_healthcheck, removed status code 000 check #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey iamejboy! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/160049395 The labels on this github issue will be updated when the story is started. |
bgandon
reviewed
Nov 21, 2018
| @@ -26,7 +26,7 @@ for NODE in "${CLUSTER_NODES[@]}"; do | |||
| set +e | |||
| status_code=$(curl -s -o "/dev/null" -w "%{http_code}" "$NODE:$GALERA_HEALTHCHECK_PORT") | |||
| set -e | |||
| if [[ $status_code -eq 000 || $status_code -eq 200 ]]; then | |||
| if [ $status_code -eq 200 ]; then | |||
There was a problem hiding this comment.
Suggested change
| if [ $status_code -eq 200 ]; then | |
| if [[ $status_code -eq 200 ]]; then |
Double square brackets are to be kept, in order to ensure that we can safely skip quoting around the $status_code variable.
|
Hi @APShirley , any chance that this could be merge soon? Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bug Description
Removed
000herecf-mysql-release/jobs/mysql/templates/drain.sh
Line 32 in 4c657b3
Update put on spec desc, "---skip-drain flag is required in order to delete a deployment" then add "scaling down"
Motivation
Drain script will be more useful to make sure that cluster is healthy before shutting down the local node. Unlike when
000is added, we assume its scaling down but its not always the case. It could be a node left network/connectivity issue, crashed node, or bosh monit stopped node.Related Issue
#208
#209
#209 (comment)