fix: Bump the minimum required version of Go to go1.23.0 #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`go mod tidy` keeps trying to change the minimum version of Go in the go.mod. Looking it up, it seems like that's probably due to a dependency requiring a higher minimum version of Go than what's currently set, go1.22. We should make this change then. Also, updates the toolchain to be go1.24.0. Left it in, but not sure we care too much what this is set to.
ctlong
force-pushed
the
fix/bump-min-go-version
branch
from
4d4ac87 to
eb52f46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you submitting this PR against the develop branch?
Yes
What is this change about?
Updating the minimum required version of Go to go1.23.0.
Please provide contextual information.
If any dependencies of a module require a minimum version of Go that is greater than the minimum version of Go required by the module, then
go mod tidywill update the minimum version of the module. This is what was happening when I rango mod tidy. I've simply committed the result of that command.What version of cf-deployment have you run this cf-acceptance-test change against?
None
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
N/A
How many more (or fewer) seconds of runtime will this change introduce to CATs?
None
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
None