Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Text and Data module types #8387

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

jamesopstad
Copy link
Contributor

Fixes #000.

This builds on the support for CompiledWasm to add support for Text and Data module types.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: N/A
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: N/A

@jamesopstad jamesopstad requested review from a team as code owners March 6, 2025 21:37
Copy link

changeset-bot bot commented Mar 6, 2025

🦋 Changeset detected

Latest commit: 18a609d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jamesopstad jamesopstad changed the title Support Text and Data module types. Support Text and Data module types Mar 6, 2025
@jamesopstad jamesopstad added the vite-plugin Relating to the `@cloudflare/vite-plugin` package label Mar 6, 2025
Copy link
Contributor

github-actions bot commented Mar 6, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13738624568/npm-package-wrangler-8387

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8387/npm-package-wrangler-8387

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13738624568/npm-package-wrangler-8387 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13738624568/npm-package-cloudflare-workers-bindings-extension-8387 -O ./cloudflare-workers-bindings-extension.0.0.0-v2fe5b114c.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v2fe5b114c.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13738624568/npm-package-create-cloudflare-8387 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13738624568/npm-package-cloudflare-kv-asset-handler-8387

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13738624568/npm-package-miniflare-8387

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13738624568/npm-package-cloudflare-pages-shared-8387

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13738624568/npm-package-cloudflare-unenv-preset-8387

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13738624568/npm-package-cloudflare-vite-plugin-8387

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13738624568/npm-package-cloudflare-vitest-pool-workers-8387

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13738624568/npm-package-cloudflare-workers-editor-shared-8387

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13738624568/npm-package-cloudflare-workers-shared-8387

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13738624568/npm-package-cloudflare-workflows-shared-8387

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250224.0
workerd 1.20250224.0 1.20250224.0
workerd --version 1.20250224.0 2025-02-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@jamesopstad jamesopstad force-pushed the james/support-all-module-types branch from a0ad81d to 64af99c Compare March 7, 2025 14:55
@jamesopstad jamesopstad force-pushed the james/support-all-module-types branch from 64af99c to 18a609d Compare March 8, 2025 14:38
@jamesopstad jamesopstad marked this pull request as draft March 8, 2025 14:40
@jamesopstad
Copy link
Contributor Author

Switched to draft because I've realised we need to add some additional handling to invalidate the modules when they change. Currently they are cached indefinitely so changes don't take effect until the dev server is restarted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vite-plugin Relating to the `@cloudflare/vite-plugin` package
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

2 participants