-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMAGES-1525: Add Images binding support to vitest-pool-workers #8362
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 8e48658 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
27f1bca
to
9755631
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13726137416/npm-package-wrangler-8362 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8362/npm-package-wrangler-8362 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13726137416/npm-package-wrangler-8362 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13726137416/npm-package-cloudflare-workers-bindings-extension-8362 -O ./cloudflare-workers-bindings-extension.0.0.0-va41659293.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-va41659293.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13726137416/npm-package-create-cloudflare-8362 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13726137416/npm-package-cloudflare-kv-asset-handler-8362 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13726137416/npm-package-miniflare-8362 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13726137416/npm-package-cloudflare-pages-shared-8362 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13726137416/npm-package-cloudflare-unenv-preset-8362 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13726137416/npm-package-cloudflare-vite-plugin-8362 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13726137416/npm-package-cloudflare-vitest-pool-workers-8362 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13726137416/npm-package-cloudflare-workers-editor-shared-8362 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13726137416/npm-package-cloudflare-workers-shared-8362 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13726137416/npm-package-cloudflare-workflows-shared-8362 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
9755631
to
321e40e
Compare
@@ -50,6 +50,7 @@ const WorkersPoolOptionsSchema = z.object({ | |||
miniflare: z | |||
.object({ | |||
workers: z.array(z.object({}).passthrough()).optional(), | |||
experimentalImagesLocalMode: z.oboolean(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is the best place for this to live - it could just as well be somewhere else
321e40e
to
e078316
Compare
This should be rebased on top of #8273 Additionally, I think (at least for now) we should force local mode to true? Vitest tests should be fully offline and shouldn't access the API |
e078316
to
e7a1bb3
Compare
Fixes IMAGES-1525
Adds support for the Images binding to vitest-pool-workers