Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hint when no permission to show membership info #8341

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kotkoroid
Copy link

@kotkoroid kotkoroid commented Mar 4, 2025

This pull request adds a hint to let users know that specific API token permissions might not be granted when Wrangler can't retrieve membership roles. This is similar to the behavior in a case where Wrangler is unable to fetch a user's email.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: The change is adding a hint to the localization.

@kotkoroid kotkoroid requested a review from a team as a code owner March 4, 2025 12:22
Copy link

changeset-bot bot commented Mar 4, 2025

🦋 Changeset detected

Latest commit: e258456

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 4, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13653599384/npm-package-wrangler-8341

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8341/npm-package-wrangler-8341

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13653599384/npm-package-wrangler-8341 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13653599384/npm-package-cloudflare-workers-bindings-extension-8341 -O ./cloudflare-workers-bindings-extension.0.0.0-v6ab98df0d.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v6ab98df0d.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13653599384/npm-package-create-cloudflare-8341 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13653599384/npm-package-cloudflare-kv-asset-handler-8341

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13653599384/npm-package-miniflare-8341

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13653599384/npm-package-cloudflare-pages-shared-8341

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13653599384/npm-package-cloudflare-unenv-preset-8341

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13653599384/npm-package-cloudflare-vite-plugin-8341

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13653599384/npm-package-cloudflare-vitest-pool-workers-8341

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13653599384/npm-package-cloudflare-workers-editor-shared-8341

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13653599384/npm-package-cloudflare-workers-shared-8341

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13653599384/npm-package-cloudflare-workflows-shared-8341

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250214.2
workerd 1.20250214.0 1.20250214.0
workerd --version 1.20250214.0 2025-02-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

1 participant