WIP: feat: add bYOIPv6 + endpoint + Destination IP support at locations(don;t merge yet; need cloudflare-go next version) #4805
+325
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexscaria
force-pushed
the
rex/endpoint+ipv6_support_at_location
branch
from
67f285f to
3e14762
Compare
|
changelog detected ✅ |
|
what is the plan with |
|
The feature was discontinued a while ago. It’s not coming back.
It’s also removed from docs.
What should we do here?
*Rex Scaria | | ***@***.*** ***@***.***> |
+1-480-628-9203*
…On Tue, Dec 24, 2024 at 12:10 AM Jacob Bednarz ***@***.***> wrote:
what is the plan with policy_ids here? we can't just remove it without a
migration path.
—
Reply to this email directly, view it on GitHub
<#4805 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFN7RANAA23LF24EVKIQID2HDUDTAVCNFSM6AAAAABT5PH3ECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRQGY3DAMZUGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
|
if it's no longer usable via the API or the product, we can remove it here but need to be sure no one is using it internally. if it's still usable (although deprecated), we'll need to continue to have it here but marked as deprecated. |
|
It’s no longer usable. We should remove it.
*Rex Scaria | | ***@***.*** ***@***.***> |
+1-480-628-9203*
…On Tue, Dec 24, 2024 at 9:04 PM Jacob Bednarz ***@***.***> wrote:
if it's no longer usable via the API or the product, we can remove it here
but need to be sure no one is using it internally.
if it's still usable (although deprecated), we'll need to continue to have
it here but marked as deprecated.
—
Reply to this email directly, view it on GitHub
<#4805 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFN7RHQZNER3G2OSFIXFCD2HIHCJAVCNFSM6AAAAABT5PH3ECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRRGU2DKMRRGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
|
cool. i'll PR the removal before i cut the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.