tls: add eddilithium2 support and fix eddilithium3 #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibmeu
approved these changes
Jul 3, 2024
Comment on lines
+283
to
+284
| EdDilithium2: "Ed25519-Dilithium2", | ||
| EdDilithium3: "Ed448-Dilithium3", |
There was a problem hiding this comment.
nits: should these be named differently, like Ed25519Dilithium2 and Ed448Dilithium3?
There was a problem hiding this comment.
I don't want to break current users. Let's reconsider naming when we add Ed25519-ML-DSA-44.
There was a problem hiding this comment.
is it worth creating aliases which are more precise?
Closes #175 We didn't move from eddilithium3 to eddilithium2 when dilithium3 was renamed to dilithium3.
armfazh
approved these changes
Jul 3, 2024
Lekensteyn
added a commit
that referenced
this pull request
Jul 3, 2024
To avoid having to regenerate all testdata files, add an option to control whether PQ signature algorithms are advertised. Tests were added for the client side. Since Go 1.19, FIPS-only mode must remain disabled to enable PQ sigalgs. [pwu: Go 1.17: moved parsePublicKey changes from x509/x509.go to x509/parser.go] [pwu: Go 1.22.5: add eddilithium2 support, fix eddilithium3, by Bas in #176] Co-authored-by: Christopher Patton <[email protected]> Co-authored-by: Peter Wu <[email protected]>
dfunkt
pushed a commit
to dfunkt/go
that referenced
this pull request
Aug 9, 2024
To avoid having to regenerate all testdata files, add an option to control whether PQ signature algorithms are advertised. Tests were added for the client side. Since Go 1.19, FIPS-only mode must remain disabled to enable PQ sigalgs. [pwu: Go 1.17: moved parsePublicKey changes from x509/x509.go to x509/parser.go] [pwu: Go 1.22.5: add eddilithium2 support, fix eddilithium3, by Bas in cloudflare#176] Co-authored-by: Christopher Patton <[email protected]> Co-authored-by: Peter Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #175
We didn't move from eddilithium3 to eddilithium2 when dilithium3 was renamed to dilithium3.