Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send empty keyshare extension instead of leaving it out #163

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Send empty keyshare extension instead of leaving it out #163

merged 1 commit into from
Oct 10, 2023

Conversation

bwesterb
Copy link
Member

No description provided.

Lekensteyn
Lekensteyn approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@Lekensteyn Lekensteyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AddBytes() function works with a nil parameter. LGTM.

Can you squash this in the next rebase?

@lukevalenta lukevalenta self-requested a review October 10, 2023 13:55
@bwesterb bwesterb merged commit 3086991 into cf Oct 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukevalenta lukevalenta lukevalenta approved these changes

@Lekensteyn Lekensteyn Lekensteyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwesterb @Lekensteyn @lukevalenta