Add dummy key agreement with codepoint 0xfe33 #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lekensteyn
reviewed
Oct 10, 2023
| @@ -58,6 +64,8 @@ func curveIdToCirclScheme(id CurveID) kem.Scheme { | |||
| return hybrid.Kyber768X25519() | |||
| case P256Kyber768Draft00: | |||
| return hybrid.P256Kyber768Draft00() | |||
| case DummyKex: | |||
| return hpke.KEM_X25519_HKDF_SHA256.Scheme() | |||
There was a problem hiding this comment.
What is the intended semantics of this? Are we expected to negotiate it? Can we have a test in cfkem_test.go for this identifier?
There was a problem hiding this comment.
Added test. Semantics is as explained in the comment of the CurveID.
There was a problem hiding this comment.
Thanks, the test at least assures that we won't crash.
DummyKex is a key agreeement similar in size but purposefully incompatible with X25519. The goal is to have a key agreement that servers will not support, so we can test HelloRetryRquest.
bwesterb
force-pushed
the
bas/dummy-kex
branch
from
0050cbb to
91e04f6
Compare
Lekensteyn
approved these changes
Oct 10, 2023
| @@ -58,6 +64,8 @@ func curveIdToCirclScheme(id CurveID) kem.Scheme { | |||
| return hybrid.Kyber768X25519() | |||
| case P256Kyber768Draft00: | |||
| return hybrid.P256Kyber768Draft00() | |||
| case DummyKex: | |||
| return hpke.KEM_X25519_HKDF_SHA256.Scheme() | |||
There was a problem hiding this comment.
Thanks, the test at least assures that we won't crash.
bwesterb
added a commit
that referenced
this pull request
Oct 10, 2023
DummyKex is a key agreeement similar in size but purposefully incompatible with X25519. The goal is to have a key agreement that servers will not support, so we can test HelloRetryRquest.
bwesterb
added a commit
that referenced
this pull request
Dec 6, 2023
DummyKex is a key agreeement similar in size but purposefully incompatible with X25519. The goal is to have a key agreement that servers will not support, so we can test HelloRetryRquest.
Lekensteyn
pushed a commit
that referenced
this pull request
Feb 7, 2024
DummyKex is a key agreeement similar in size but purposefully incompatible with X25519. The goal is to have a key agreement that servers will not support, so we can test HelloRetryRquest.
Lekensteyn
pushed a commit
that referenced
this pull request
Feb 9, 2024
DummyKex is a key agreeement similar in size but purposefully incompatible with X25519. The goal is to have a key agreement that servers will not support, so we can test HelloRetryRquest.
Lekensteyn
pushed a commit
that referenced
this pull request
Mar 5, 2024
DummyKex is a key agreeement similar in size but purposefully incompatible with X25519. The goal is to have a key agreement that servers will not support, so we can test HelloRetryRquest.
Lekensteyn
pushed a commit
that referenced
this pull request
Apr 5, 2024
DummyKex is a key agreeement similar in size but purposefully incompatible with X25519. The goal is to have a key agreement that servers will not support, so we can test HelloRetryRquest.
bwesterb
added a commit
that referenced
this pull request
May 6, 2024
DummyKex is a key agreeement similar in size but purposefully incompatible with X25519. The goal is to have a key agreement that servers will not support, so we can test HelloRetryRquest.
bwesterb
added a commit
that referenced
this pull request
May 7, 2024
DummyKex is a key agreeement similar in size but purposefully incompatible with X25519. The goal is to have a key agreement that servers will not support, so we can test HelloRetryRquest.
dfunkt
pushed a commit
to dfunkt/go
that referenced
this pull request
Jun 11, 2024
DummyKex is a key agreeement similar in size but purposefully incompatible with X25519. The goal is to have a key agreement that servers will not support, so we can test HelloRetryRquest.
bwesterb
added a commit
that referenced
this pull request
Jun 23, 2024
DummyKex is a key agreeement similar in size but purposefully incompatible with X25519. The goal is to have a key agreement that servers will not support, so we can test HelloRetryRquest.
Lekensteyn
pushed a commit
that referenced
this pull request
Jul 3, 2024
DummyKex is a key agreeement similar in size but purposefully incompatible with X25519. The goal is to have a key agreement that servers will not support, so we can test HelloRetryRquest.
Lekensteyn
pushed a commit
that referenced
this pull request
Jul 4, 2024
DummyKex is a key agreeement similar in size but purposefully incompatible with X25519. The goal is to have a key agreement that servers will not support, so we can test HelloRetryRquest.
dfunkt
pushed a commit
to dfunkt/go
that referenced
this pull request
Aug 9, 2024
DummyKex is a key agreeement similar in size but purposefully incompatible with X25519. The goal is to have a key agreement that servers will not support, so we can test HelloRetryRquest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DummyKex is a key agreeement similar in size but purposefully incompatible with X25519. The goal is to have a key agreement that servers will not support, so we can test HelloRetryRquest.