Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cfgo build tag and add a test #156

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Fix cfgo build tag and add a test #156

merged 1 commit into from
Oct 2, 2023

Conversation

bwesterb
Copy link
Member

@bwesterb bwesterb commented Oct 2, 2023

No description provided.

@bwesterb bwesterb requested a review from Lekensteyn October 2, 2023 11:35
Lekensteyn
Lekensteyn approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@Lekensteyn Lekensteyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During the next rebase, we should replace the cmd/go/internal/imports, go/build: add cfgo build tag commit with it.

@bwesterb bwesterb merged commit 3ae245e into cf Oct 2, 2023
2 checks passed
@bwesterb bwesterb deleted the bas/fix-build-tag branch October 2, 2023 12:03
bwesterb added a commit that referenced this pull request Oct 6, 2023
@bwesterb
cmd/go/internal/imports, go/build: add cfgo build tag
0a3cea3 
This allows applications to use build tags to maintain compatibility
with both this fork as well as standard Go.

[ bas 2023-10-6) Fix cfgo build tag and add a test (#156) ]
bwesterb added a commit that referenced this pull request Oct 6, 2023
@bwesterb
cmd/go/internal/imports, go/build: add cfgo build tag
234e51f 
This allows applications to use build tags to maintain compatibility
with both this fork as well as standard Go.

[ bas 2023-10-6: Fix cfgo build tag and add a test (#156) ]
bwesterb added a commit that referenced this pull request Oct 10, 2023
@bwesterb
cmd/go/internal/imports, go/build: add cfgo build tag
8ad2aeb 
This allows applications to use build tags to maintain compatibility
with both this fork as well as standard Go.

[ bas 2023-10-6: Fix cfgo build tag and add a test (#156) ]
bwesterb added a commit that referenced this pull request Dec 6, 2023
@bwesterb
cmd/go/internal/imports, go/build: add cfgo build tag
cda8911 
This allows applications to use build tags to maintain compatibility
with both this fork as well as standard Go.

[ bas 2023-10-6: Fix cfgo build tag and add a test (#156) ]
Lekensteyn pushed a commit that referenced this pull request Feb 7, 2024
@bwesterb @Lekensteyn
cmd/go/internal/imports, go/build: add cfgo build tag
3aca896 
This allows applications to use build tags to maintain compatibility
with both this fork as well as standard Go.

[ bas 2023-10-6: Fix cfgo build tag and add a test (#156) ]
Lekensteyn pushed a commit that referenced this pull request Mar 5, 2024
@bwesterb @Lekensteyn
cmd/go/internal/imports, go/build: add cfgo build tag
afa7242 
This allows applications to use build tags to maintain compatibility
with both this fork as well as standard Go.

[ bas 2023-10-6: Fix cfgo build tag and add a test (#156) ]
Lekensteyn pushed a commit that referenced this pull request Apr 5, 2024
@bwesterb @Lekensteyn
cmd/go/internal/imports, go/build: add cfgo build tag
10d5b04 
This allows applications to use build tags to maintain compatibility
with both this fork as well as standard Go.

[ bas 2023-10-6: Fix cfgo build tag and add a test (#156) ]
bwesterb added a commit that referenced this pull request May 6, 2024
@bwesterb
cmd/go/internal/imports, go/build: add cfgo build tag
dbff213 
This allows applications to use build tags to maintain compatibility
with both this fork as well as standard Go.

[ bas 2023-10-6: Fix cfgo build tag and add a test (#156) ]
bwesterb added a commit that referenced this pull request May 7, 2024
@bwesterb
cmd/go/internal/imports, go/build: add cfgo build tag
3883466 
This allows applications to use build tags to maintain compatibility
with both this fork as well as standard Go.

[ bas 2023-10-6: Fix cfgo build tag and add a test (#156) ]
dfunkt pushed a commit to dfunkt/go that referenced this pull request Jun 11, 2024
@bwesterb @dfunkt
cmd/go/internal/imports, go/build: add cfgo build tag
247cb4d 
This allows applications to use build tags to maintain compatibility
with both this fork as well as standard Go.

[ bas 2023-10-6: Fix cfgo build tag and add a test (cloudflare#156) ]
bwesterb added a commit that referenced this pull request Jun 23, 2024
@bwesterb
cmd/go/internal/imports, go/build: add cfgo build tag
ab1508a 
This allows applications to use build tags to maintain compatibility
with both this fork as well as standard Go.

[ bas 2023-10-6: Fix cfgo build tag and add a test (#156) ]
Lekensteyn pushed a commit that referenced this pull request Jul 3, 2024
@bwesterb @Lekensteyn
cmd/go/internal/imports, go/build: add cfgo build tag
12d930d 
This allows applications to use build tags to maintain compatibility
with both this fork as well as standard Go.

[ bas 2023-10-6: Fix cfgo build tag and add a test (#156) ]
dfunkt pushed a commit to dfunkt/go that referenced this pull request Aug 9, 2024
@bwesterb @dfunkt
cmd/go/internal/imports, go/build: add cfgo build tag
2e5e51b 
This allows applications to use build tags to maintain compatibility
with both this fork as well as standard Go.

[ bas 2023-10-6: Fix cfgo build tag and add a test (cloudflare#156) ]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lekensteyn Lekensteyn Lekensteyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwesterb @Lekensteyn