Add tls.Config.CurveGuess to allow specifying which keyshares to send #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukevalenta
reviewed
Sep 28, 2023
bwesterb
force-pushed
the
bas/custom-keyshares
branch
from
cc5fc76 to
87c022f
Compare
SulemanAhmadd
requested review from
SulemanAhmadd
and removed request for
SulemanAhmadd
bwesterb
force-pushed
the
bas/custom-keyshares
branch
2 times, most recently
from
48f3f66 to
5a7dd4f
Compare
lukevalenta
approved these changes
Sep 29, 2023
bwesterb
force-pushed
the
bas/custom-keyshares
branch
from
5b42f1d to
8cc8f19
Compare
SulemanAhmadd
approved these changes
Sep 29, 2023
Lekensteyn
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
LGTM.
Interesting detail that is not documented here: some implementations (OpenSSL) use the order of ClientCurveGuess (key_shares) to select the final key share. Others (boringssl, Go crypto/tls) determine the expected key share based on the CurvePreferences (supported_groups) setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.