[Docs Site] Remove trailing whitespace from Type component #20275
+27
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KianNH
requested review from
kristianfreeman,
kodster28,
pedrosousa,
haleycode,
maxvp,
marciocloudflare,
GregBrimble,
WalshyDev and
a team
as code owners
|
Howdy and thanks for contributing to our repo. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. |
github-actions
bot
assigned GregBrimble, haleycode, kodster28, kristianfreeman, marciocloudflare, maxvp, pedrosousa and WalshyDev
|
Preview URL: https://730ab137.preview.developers.cloudflare.com |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -2,6 +2,8 @@ import { experimental_AstroContainer } from "astro/container"; | |||
| import { getContainerRenderer } from "@astrojs/mdx"; | |||
| import { loadRenderers } from "astro:container"; | |||
| import { render, type CollectionEntry } from "astro:content"; | |||
| import type { AstroComponentFactory } from "astro/runtime/server/index.js"; | |||
| import type { AstroGlobal } from "astro"; | |||
There was a problem hiding this comment.
🚫 [eslint] <@typescript-eslint/no-unused-vars> reported by reviewdog 🐶
'AstroGlobal' is defined but never used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Components with whitespace between the markup and style tags result in trailing whitespace.
A possible proposal, albeit a breaking change, is tracked at withastro/roadmap#868
This fixes the issue in the interim - there are workarounds, like wrapping the markup in a fragment, but they do not apply to components we don't control (i.e the Starlight
Badge) so we just render it to HTML and trim the whitespace.