Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret bindings note - replaced Pages content with partial #19761

Merged

Conversation

ToriLindsay
Copy link
Contributor

Fixes #18089

@ToriLindsay
Copy link
Contributor Author

@vicb I assume it makes sense to ask you to review this one considering I remember you just updated this partial in #19340 / #19489 ? Thank you!

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change!

The partial says "When developing your Worker or Pages Function ..." so very appropriate here!

@bllchmbrs
Copy link
Contributor

Ignore the Hyperlint Errors on this PR. (- Hyperlint dev)

@ToriLindsay ToriLindsay merged commit ed21c4d into production Mar 6, 2025
11 checks passed
@ToriLindsay ToriLindsay deleted the tori/pcx18089-add-secret-bindings-note-to-pages branch March 6, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pages Secret bindings missing reference to environments for local dev
7 participants