Remove "fips-no-compat", decouple "fips-compat" from "fips" #333
+21
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
force-pushed
the
cjpatton/fips-compat-decouple
branch
2 times, most recently
from
17b0986 to
9469c61
Compare
cjpatton
changed the title
cjpatton
force-pushed
the
cjpatton/fips-compat-decouple
branch
from
9469c61 to
61303e3
Compare
cjpatton
force-pushed
the
cjpatton/update-bindings-for-latest-bssl
branch
from
f73439d to
b6708f8
Compare
cjpatton
force-pushed
the
cjpatton/fips-compat-decouple
branch
from
61303e3 to
1c90cfe
Compare
Base automatically changed from
cjpatton/update-bindings-for-latest-bssl
to
master
March 14, 2025 22:22
Modify the "fips" feature so that it no longer implies "fips-compat". The latter is no longer needed for recent builds of boringSSL; users who need older builds will need to enable "fips-compat" explicitly. Also, remove the "fipps-no-compat" feature, as it's now equivalent to "fips".
cjpatton
force-pushed
the
cjpatton/fips-compat-decouple
branch
from
1c90cfe to
6f83572
Compare
|
Rebased. |
kornelski
approved these changes
Mar 16, 2025
|
HI @kornelski, this shouldn't have been merged, at least not yet until we're ready to cut a release with API breaking changes. cc @rushilmehra |
|
Sorry I thought we're already on the way to 5.0 |
I hope we are close, but Rushil asked to hold off. I'm resubmitting this PR as a draft and will tag you both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #332 (merge that first).
Partially addresses #196.
NOTE: This is an API breaking change.
Modify the "fips" feature so that it no longer implies "fips-compat".
The latter is no longer needed for recent builds of boringSSL; users who
need older builds will need to enable "fips-compat" explicitly.
Also, remove the "fipps-no-compat" feature, as it's now equivalent to
"fips".