Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved django-babel into hue repo #3941

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

amitsrivastava
Copy link
Collaborator

django-babel has been out of maintenance for a while. We forked it several years ago and have been updating it to support newer and newer django versions. This commit brings the whole django-babel code into our repo and makes it simpler to maintain it in future. This will also allow us to make django upgrade changes in lock-step with the hue app.

What changes were proposed in this pull request?

  • (Please fill in changes proposed in this fix)

How was this patch tested?

  • (Please explain how this patch was tested. Ex: unit tests, manual tests)
  • (If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Hue Contributing Guide before opening a pull request.

django-babel has been out of maintenance for a while. We forked it
several years ago and have been updating it to support newer and newer
django versions. This commit brings the whole django-babel code into
our repo and makes it simpler to maintain it in future. This will also
allow us to make django upgrade changes in lock-step with the hue app.
Copy link
Collaborator

@Harshg999 Harshg999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change!

Copy link
Collaborator

@agl29 agl29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amitsrivastava amitsrivastava enabled auto-merge (rebase) January 8, 2025 14:08
@amitsrivastava amitsrivastava merged commit 642146b into master Jan 8, 2025
5 of 6 checks passed
@amitsrivastava amitsrivastava deleted the dev/amit/move-django-babel-into-hue branch January 8, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants