Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trino] Ensures uninterrupted schema listing even if a catalog query fails #3939

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

agl29
Copy link
Collaborator

@agl29 agl29 commented Jan 6, 2025

What changes were proposed in this pull request?

  • Logs errors for failed catalog queries and continues processing other catalogs without interruption.

How was this patch tested?

  • Unit test
  • Manually

Copy link
Collaborator

@Harshg999 Harshg999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agl29 agl29 force-pushed the trino_db_list_error branch from e1d34a2 to 5f090aa Compare January 6, 2025 08:27
Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@agl29 agl29 merged commit 77faef4 into master Jan 6, 2025
6 checks passed
@agl29 agl29 deleted the trino_db_list_error branch January 6, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants