Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui-storagebrowser] adds delete action for files and folder #3926

Merged
merged 4 commits into from
Jan 7, 2025
Merged

[ui-storagebrowser] adds delete action for files and folder #3926

merged 4 commits into from
Jan 7, 2025

Conversation

ramprasadagarwal
Copy link
Collaborator

What changes were proposed in this pull request?

  • adds the delete action in the file browser

How was this patch tested?

  • Added unit tests

@ramprasadagarwal ramprasadagarwal self-assigned this Dec 19, 2024
nidhibhatg
nidhibhatg approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@nidhibhatg nidhibhatg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nidhibhatg
nidhibhatg reviewed Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@nidhibhatg nidhibhatg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add view trash folder functionality

JohanAhlen
JohanAhlen approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Base automatically changed from improv/browser-actions-refactor to master January 7, 2025 10:44
@ramprasadagarwal ramprasadagarwal enabled auto-merge (squash) January 7, 2025 10:47
@ramprasadagarwal ramprasadagarwal merged commit 28e761c into master Jan 7, 2025
5 of 6 checks passed
@ramprasadagarwal ramprasadagarwal deleted the feat/delete-action branch January 7, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nidhibhatg nidhibhatg nidhibhatg approved these changes

@JohanAhlen JohanAhlen JohanAhlen approved these changes

@tabraiz12 tabraiz12 Awaiting requested review from tabraiz12

@bjornalm bjornalm Awaiting requested review from bjornalm

Assignees

@ramprasadagarwal ramprasadagarwal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramprasadagarwal @JohanAhlen @nidhibhatg