-
Notifications
You must be signed in to change notification settings - Fork 37
Initial migration to Terraform Plugin Framework #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial migration to Terraform Plugin Framework #279
Conversation
Do you want to rebase? Seeing you make such nice commits I'm hesitant to click the |
173b919
to
bb90409
Compare
Thanks for the contribution, very appreciated. After internal discussions and how we want to prioritize our work. Migrating to framework will be put on hold until August/September to finish our other tasks before the summer. We will definitely keep an eye of any changes here. |
Thanks for the feedback @tbroden84 I understand the concern of merging this right away. I was just trying to fix #214 as soon as I could as it is something that affects the infra I manage for my employee. I will continue rebasing this MR as it is required. Ping me if you would like some help in other places |
bb90409
to
059151f
Compare
059151f
to
f94a12b
Compare
c8c65d2
to
2e3e08d
Compare
2e3e08d
to
ac3b427
Compare
Hi @tbroden84 & @dentarg I just rebased the branch again, let me know if you need something from my end :) |
@tete17 thanks. Expect small fixes to the provider we unfortunately still have this task on hold until later. Currently internal tasks that are higher prioritized. |
ac3b427
to
9a70d09
Compare
Friendly trimestral reminder that this is still open. No rush I know it is not priority ;) I may start working on the migration of the resource I really want in parallel |
We haven't forgot about this :) But unfortunately still occupied with more prioritized tasks. |
0b1aadd
to
a86248d
Compare
a86248d
to
15b7e97
Compare
Happy 2025 :) |
15b7e97
to
b5032c4
Compare
b5032c4
to
5146f7b
Compare
This is in preparation to migrate to the plugin framework.
This combined with the muxing will allow us to migrate resources and datasources one at a time
…rm plugin framework This is the first resource to move towards the new system and should serve as a template for all others. The reason to choose this one as the first is because it is the smallest file that still has tests to prove everything still works as before.
5146f7b
to
58054ce
Compare
Hi @tbroden84 & @dentarg To celebrate the one year anniversary of the MR I just rebased the branch again, let me know if you need something from my end :) |
@tete17 thanks :) Sorry for not yet prioritizing this. Will lift it up on our next internal weekly meeting. |
I discussed this with my colleagues during our last development meeting, and we all agreed to dedicate more effort to this initiative. As a first step, I’ve already created a feature branch: framework migration. I’ll update this PR to target that branch (instead of main) and merge it. From there, we can continue upgrading additional resources until the entire provider is ready to be merged into main and complete the migration. I’ve also started updating issue #281 to track the migration progress. |
Hi @tbroden84 Thanks for merging this. I will be honest I am a bit confused. The whole idea of this is to be able to slowly merge this MR and do small incremental releases. Minimizing the risk of breaking people integration. Separating this into its own branch, I suspect, in an effort to merge it all together feels unnecessary risky. You will get a ton of conflicts and I doubt renovatebot will open MR against this new branch. I of course don't have a say on any of this so consider this my humble opinion. Pleasure working with you guys :) |
@tete17 you are right, doing the feature branch will complicate things more. |
Happy to do so if you like but you can also merge the branch you created into master. Let me know |
Please go ahead, then we can also give credit where credit is due :) |
This is the first of many resources to be migrated to the Hashicorp Plugin Framework.
I chose this one because it was the smallest file that still contained test to make sure I could prove nothing had changed.
This 3 MR does 3 things:
cloudamqp_intregration_aws_eventbridge
to the new provider making sure test are not broken.Hopefully this migration will allow us to tackle issues like #214
The error messages are fairly barebones as I haven't given them too much though feel free to suggest a full rewrite on them, I focused on making the main path work, error messages are mostly an afterthought.