feat(dia.Graph): remove base cell collection #3082
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to update tests, and check more stuff, but overall structure is done |
kumilingus
reviewed
Oct 23, 2025
| // The elements come after the links. | ||
| var cells = collection.sortBy(function(cell) { | ||
| return cell.isLink() ? 1 : 2; | ||
| const sortedCells = cells.sort((a, b) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove base cell collection and move logic to the cell layers instead
events
All cell events are emitted without prefix.
All layer model events and cell collection events are emitted with
layer:prefix, e.g.layer:resetis emited when layer collection has been reset, andlayer:changewhen the layer's attribute has been changed.All layer collection events are emited with
layers:prefix, e.g.layers:resetwhen whole cellLayerCollection has been reset.