(WIP) refactor(@joint/layout-directed-graph): avoid indirect function calls in API #2599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbynekstara
changed the title
zbynekstara
force-pushed
the
improve-directed-graph-layout-api
branch
from
76a5452
to
ea21591
Compare
zbynekstara
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The old API of DirectedGraph had to count with the possibility that the API is being called from the
dia.Graphobject. To be able to do that, it made use ofcallandbindmethods. With the separation of DirectedGraph as a separate plugin, there is no longer any need for these complications.Also fixes the docs of the
fromGraphLib()function for the case where a new JointJS Graph is created from a Graphlib graph, and adds a test.