refactor(shared): rename clerk-rq directory to query#8445
refactor(shared): rename clerk-rq directory to query#8445jacekradko wants to merge 13 commits intomainfrom
Conversation
…-ownership # Conflicts: # packages/clerk-js/package.json # packages/shared/package.json # pnpm-lock.yaml
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: edca0c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…-dir # Conflicts: # packages/shared/src/react/hooks/__tests__/mocks/clerk.ts # packages/shared/src/react/index.ts # packages/shared/src/react/query/__tests__/clerk-query-client.spec.ts # packages/shared/src/react/query/clerk-query-client.ts
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (12)
✅ Files skipped from review due to trivial changes (11)
📝 WalkthroughWalkthroughThis pull request renames internal React query import paths across the shared package: files that previously imported from Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Summary
Renames
packages/shared/src/react/clerk-rq/→packages/shared/src/react/query/. Therqshorthand was opaque ("react-query");query/reads naturally and matches the existing function vocabulary (useClerkQuery,getClerkQueryClient,useClerkInfiniteQuery).Pure directory rename — no behavior change, no public surface change. The
clerk-rqpath was internal to@clerk/shared(which itself is described as an internal SDK utility package); not exposed via subpath exports, not referenced in any CHANGELOG or docs.11 files relocated, 16 import sites updated, two doc comments refreshed. The stable
__tag: 'clerk-rq-client'runtime identifier inmocks/clerk.tsis intentionally untouched to avoid behavior churn.Stacking
Based on
jacek/clerk-rq-invert-ownership(#8434). Will need to be retargeted tomainonce that PR merges, or merged through it.Test plan
pnpm --filter @clerk/shared test— 1076 tests pass, no type errorspnpm --filter @clerk/shared build— cleangrep clerk-rqreturns only the deliberate runtime tag and the parent PR's changeset