Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backend): Allow to create organizations without initial owner #4670

Conversation

LauraBeatris
Copy link
Member

@LauraBeatris LauraBeatris commented Nov 29, 2024

Description

Resolves ORGS-144, ORGS-392

As part of SSO per org (https://github.com/clerk/clerk_go/pull/7782), we've updated BAPI to allow creating organizations without an owner therefore turning createdBy from required to optional. This unblocks B2B customers to create empty organizations as part of onboarding.

Docs PR: clerk/clerk-docs#1754

Is this a breaking change?

Proposing this a minor version update, although not a breaking change according to our definitions, some customers might be relying on the fact that organizations always have an owner.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@LauraBeatris LauraBeatris self-assigned this Nov 29, 2024
Copy link

changeset-bot bot commented Nov 29, 2024

🦋 Changeset detected

Latest commit: 86b45a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@clerk/backend Minor
@clerk/astro Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/tanstack-start Patch
@clerk/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 5:28pm

@LauraBeatris LauraBeatris force-pushed the laura/orgs-392-update-createdby-to-be-optional-when-creating-organization branch from 3026221 to 00c6cf7 Compare November 29, 2024 17:20
@LauraBeatris LauraBeatris force-pushed the laura/orgs-392-update-createdby-to-be-optional-when-creating-organization branch from 00c6cf7 to 356b90d Compare November 29, 2024 17:24
@LauraBeatris LauraBeatris force-pushed the laura/orgs-392-update-createdby-to-be-optional-when-creating-organization branch from 356b90d to 86b45a1 Compare November 29, 2024 17:25
@LauraBeatris LauraBeatris marked this pull request as ready for review November 29, 2024 17:43
@LauraBeatris LauraBeatris requested a review from a team November 29, 2024 17:43
Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks straightforward.

@LauraBeatris LauraBeatris merged commit b6aa589 into main Dec 2, 2024
31 checks passed
@LauraBeatris LauraBeatris deleted the laura/orgs-392-update-createdby-to-be-optional-when-creating-organization branch December 2, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants