Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] chore(clerk-js): Fix transform css rule in outAnimation #4660

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kaftarmery
Copy link

@kaftarmery kaftarmery commented Nov 26, 2024

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 9:13am

Copy link

changeset-bot bot commented Nov 26, 2024

🦋 Changeset detected

Latest commit: 03546f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kaftarmery kaftarmery changed the title Typo fix [fix] Transform syntax typo Nov 26, 2024
Copy link
Member

@alexcarpenter alexcarpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaftarmery good catch.

Will need to update the PR title to the format required. e.g. fix(clerk-js): Fix typo in outAnimation as an example.

Will also need to generate a changeset, which can be triggered via npx changeset in the repo, and follow the steps. https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md

@kaftarmery kaftarmery changed the title [fix] Transform syntax typo chore(clerk-js): Fix transform css rule in outAnimation Nov 27, 2024
packages/clerk-js/.changeset/README.md Outdated Show resolved Hide resolved
packages/clerk-js/.changeset/config.json Outdated Show resolved Hide resolved
Comment on lines +1 to +2
---
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a changeset here! It's a change that impacts the customers.

@panteliselef panteliselef changed the title chore(clerk-js): Fix transform css rule in outAnimation [WIP] chore(clerk-js): Fix transform css rule in outAnimation Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants