feat(clerk-js): Add static toast UI for Keyless mode #4658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: d243198 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kaftarmery
changed the title
anagstef
previously requested changes
Nov 28, 2024
kaftarmery
dismissed
anagstef’s stale review
Request change has been resolved
anagstef
reviewed
Nov 28, 2024
| @@ -0,0 +1,236 @@ | |||
| export function ClerkLogoIcon() { | |||
There was a problem hiding this comment.
🔧 Can we move this icon into the /ui/icons folder as a .svg file and then export it from the /ui/index.ts file as we do with all of our icons?
anagstef
reviewed
Nov 28, 2024
| @@ -0,0 +1,19 @@ | |||
| export function KeySlashIcon() { | |||
anagstef
reviewed
Nov 28, 2024
| } | ||
| `} | ||
| > | ||
| Claim keys |
There was a problem hiding this comment.
This text probably needs to be using localization (?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
This PR introduces the new static Toast UI for Keyless mode