Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nextjs): Investigate notFound error #4638

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
+6 −2
Draft

feat(nextjs): Investigate notFound error #4638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f577cd3
feat: notFound error
jacekradko Nov 22, 2024
c640f25
WIP
jacekradko Nov 22, 2024
424ea71
WIP
jacekradko Nov 23, 2024
56bed7c
Merge branch 'main' into feat/not-found-error
jacekradko Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/strong-carrots-build.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
6 changes: 4 additions & 2 deletions packages/nextjs/src/server/protect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,16 @@ export function createProtect(opts: {
// TODO: Handle runtime values. What happens if runtime values are set in middleware and in ClerkProvider as well?
return redirectToSignIn();
}
return notFound();
notFound();
return;
};

const handleUnauthorized = () => {
if (unauthorizedUrl) {
return redirect(unauthorizedUrl);
}
return notFound();
notFound();
return;
};

/**
Expand Down
Loading