feat(clerk-js,types): Add navbar button text descriptor and localization key #4635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 7fa0dab The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alexcarpenter
changed the title
alexcarpenter
changed the title
alexcarpenter
commented
Nov 25, 2024
| const customElements = screen.getAllByText(/Custom1/i); | ||
| expect(customElements.some(el => el.tagName.toUpperCase() === 'BUTTON')).toBe(true); | ||
| const externalElements = screen.getAllByText(/ExternalLink/i); | ||
| expect(externalElements.some(el => el.tagName.toUpperCase() === 'BUTTON')).toBe(true); |
There was a problem hiding this comment.
Update selectors using best practices https://kentcdodds.com/blog/common-mistakes-with-react-testing-library#not-using-byrole-most-of-the-time
panteliselef
approved these changes
Nov 26, 2024
Comment on lines
+107
to
+111
| <Span | ||
| elementDescriptor={descriptors.navbarButtonText} | ||
| elementId={descriptors.navbarButtonText.setId(r.id as any)} | ||
| localizationKey={r.name} | ||
| /> |
There was a problem hiding this comment.
❓ Could this be replaced with <Text as="span"/> ?
There was a problem hiding this comment.
No because of the default styles the <Text /> component applies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently userprofile navbar buttons don't have visible localization keys since the have a icon within the button, since when a localizationKey is provided, the icon gets removed due to makeLocalizeable converting the children to a string. I had trouble tracking down the localization key for the navbar buttons since it was not visible in the dom as expected.
I am proposing introducing a generic that can be used to hold the localization key. Text as span currently carries styles that may not be intended in use.
Example:
Resolves SDKI-769
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change