Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-router): Update playground & pkg #4628

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Nov 22, 2024

Description

PR to the WIP @clerk/react-router package fixing the playground. Changes made:

  • Update @remix-run imports to react-router
  • Replaced the deprecated json() with Response.json(). Related deprecation comment here.
  • Commented the deprecated defer() and isDeferredData() for now. Related deprecation comment here.
  • I used yalc to run the playground with npm
  • Added esm build as I'm getting module is not defined errors with @clerk/react-router/ssr.server (pretty sure this can be fixed, but I think publishing esm is also a good idea)

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Nov 22, 2024

⚠️ No Changeset found

Latest commit: 5ec5ccc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 9:33am

@LekoArts LekoArts changed the title WIP: Fix React Router playground fix(react-router): Update playground & pkg Nov 22, 2024
@LekoArts LekoArts marked this pull request as ready for review November 22, 2024 09:33
@LekoArts LekoArts merged commit 4e3a4df into lekoarts/eco-247-bootstrap-new-package Nov 22, 2024
5 of 6 checks passed
@LekoArts LekoArts deleted the rob/react-router-fix branch November 22, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants