fix(clerk-js): Propagate redirectUrl when continuing sign up with missing identifier
#4542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LauraBeatris
changed the title
redirectUrl on sign up continueredirectUrl when continuing sign up with missing identifier
LauraBeatris
changed the title
redirectUrl when continuing sign up with missing identifier redirectUrl when continuing sign up with missing identifier
LauraBeatris
changed the title
redirectUrl when continuing sign up with missing identifier redirectUrl when continuing sign up with missing identifier
LauraBeatris
changed the title
redirectUrl when continuing sign up with missing identifier redirectUrl when continuing sign up with missing identifier
| @@ -150,6 +152,9 @@ function _SignUpContinue() { | |||
| card.setLoading(); | |||
| card.setError(undefined); | |||
|
|
|||
| const redirectUrl = buildSSOCallbackURL(ctx, displayConfig.signUpUrl); | |||
| const redirectUrlComplete = ctx.afterSignUpUrl || '/'; | |||
There was a problem hiding this comment.
🙃 I believe we already properly resolve this inside the RedirectUrls class
Suggested change
| const redirectUrlComplete = ctx.afterSignUpUrl || '/'; | |
| const redirectUrlComplete = ctx.afterSignUpUrl |
| @@ -150,6 +152,9 @@ function _SignUpContinue() { | |||
| card.setLoading(); | |||
| card.setError(undefined); | |||
|
|
|||
| const redirectUrl = buildSSOCallbackURL(ctx, displayConfig.signUpUrl); | |||
There was a problem hiding this comment.
I see that we do this constantly, does it make sense to move it inside useSignUpContext ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When SSO connections return no email claim, users are correctly prompted for their email but encounter an error due to missing
action_complete_redirect_urlduring submission.We should continue to sign up by calling
completeSignUpFlowwith theredirectUrlso that it can call the SSO callback correctly.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Fixes ORGS-328