fix(clerk-js): Prevent memory leak in worker timers setTimeout #4515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8912ef3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
myandrienko
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@BRKalow Anything else I can do here to help this get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating a timeout using worker timers, timeout callback is saved on the page side in map, and a mapping between page-side id and worker-side id is saved in an object in the worker.
Both of these entries are only cleaned up if the timeout is canceled with
clearTimeout. Normally this isn't done. So even after timeout has fired, related entries are kept, causing a memory leak. It's especially noticeable whensetTimeoutis called recursively, as is done inPollerused by email link flow.This PR cleans timeout-related entries once the timer has successfully fired.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change