-
Notifications
You must be signed in to change notification settings - Fork 361
feat(clerk-js,localizations,types): Enable email verification in UserProfile
via enterprise SSO
#4406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat(clerk-js,localizations,types): Enable email verification in UserProfile
via enterprise SSO
#4406
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
506d032
wip
NicolasLopes7 f2deba4
Use enterprise SSO as strategy
LauraBeatris 9cf7052
Rename verification hook to enterprise SSO
LauraBeatris 52c74f2
Rename `matchesEnterpriseConnection` to `hasEnterpriseSso`
LauraBeatris 5728883
fix types
NicolasLopes7 ce5b660
Introduce localization key for enterprise SSO
LauraBeatris d733090
Do not declare verification success component within enterprise context
LauraBeatris 38bbabc
Add changeset
LauraBeatris 2293ab4
Define noopener when opening external verification URL
LauraBeatris 24094ff
Remove `console.log`
LauraBeatris 7c5b49d
Fix translation key for email code
LauraBeatris 78fa7e0
Use unified form hint for all verification strategies
LauraBeatris c6eaa66
Update test with latest translation key
LauraBeatris ef40cde
Re-generate localization files
LauraBeatris eea850c
rename: `has_enterprise_sso` -> `matches_sso_connection`
NicolasLopes7 c3cbcfa
Fix gap between provider and email address
LauraBeatris a5815ac
Fix rebase
LauraBeatris fddfdda
Update changeset
LauraBeatris 3313081
chore: Preserve `UserProfile` modal behavior
LauraBeatris 21d5b9b
chore: Preserve `UserProfile` modal behavior
LauraBeatris e899573
Update pt-BR translation
LauraBeatris 9944630
Cover de-DE translation
LauraBeatris 7789738
Update UI test
LauraBeatris b0174d1
Adjust SSO casing
LauraBeatris 58318d5
Serve previous form hints for older clerk-js versions
LauraBeatris 9cc2331
Update error message for `EmailAddress` type
LauraBeatris b32cf69
Add JSDocs to clarify strategy resolution
LauraBeatris 00101f0
Refactor flow to initiate SSO on button click
LauraBeatris 95f19a3
Improve copy of form hint translation
LauraBeatris 315276c
Remove unnecessary error from `EmailAddress` resource
LauraBeatris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@clerk/types': minor | ||
--- | ||
|
||
Deprecated `userProfile.emailAddressPage.emailLink.formHint` and `userProfile.emailAddressPage.emailCode.formHint` in favor of `userProfile.emailAddressPage.formHint` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@clerk/localizations': minor | ||
--- | ||
|
||
Unified `formHint` under `userProfile.emailAddressPage` for all first factor auth methods |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@clerk/clerk-js': minor | ||
--- | ||
|
||
Enable email verification in `UserProfile` via enterprise SSO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes an issue with the spacing between the provider and email address:
With gap 1:
With gap 2: