feat(clerk-js,shared,types,localizations): New client_mismatch status for email link sign in/up #3367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c63b451 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mzhong9723
commented
May 10, 2024
packages/localizations/src/en-US.ts
Outdated
Comment on lines
329
to
330
| subtitle: | ||
| 'Open the verification link on the device and browser from which you initiatied the sign in to continue', |
There was a problem hiding this comment.
🔧 Suggestions welcome to improve these messages!
There was a problem hiding this comment.
I find it a bit long, but i cannot think of a shorter version atm.
LekoArts
requested changes
May 13, 2024
.changeset/tricky-tomatoes-repair.md
Outdated
| '@clerk/types': minor | ||
| --- | ||
|
|
||
| Introduce new `client_mismatch` verification status for email link sign in and sign up |
There was a problem hiding this comment.
Suggested change
| Introduce new `client_mismatch` verification status for email link sign in and sign up | |
| Introduce new `client_mismatch` verification status for email link sign-in and sign-up. This error (and its message) will be shown if a verification link was opened in another device/browser from which the user initiated the sign-in/sign-up attempt. This functionality needs to be enabled in the Clerk dashboard. |
More details on how this works and what it does
packages/localizations/src/en-US.ts
Outdated
| @@ -325,6 +325,11 @@ export const enUS: LocalizationResource = { | |||
| subtitleNewTab: 'Return to the newly opened tab to continue', | |||
| titleNewTab: 'Signed in on other tab', | |||
| }, | |||
| clientMismatch: { | |||
| subtitle: | |||
| 'Open the verification link on the device and browser from which you initiatied the sign in to continue', | |||
There was a problem hiding this comment.
Suggested change
| 'Open the verification link on the device and browser from which you initiatied the sign in to continue', | |
| 'To continue, open the verification link on the device and browser from which you initiated the sign-in', |
Typo fix, use the proper noun for sign-in (sign in is the verb), and move the "to continue" to start.
Reads better to me :)
There was a problem hiding this comment.
Reads better to me as well, thanks!
packages/localizations/src/en-US.ts
Outdated
| clientMismatch: { | ||
| subtitle: | ||
| 'Open the verification link on the device and browser from which you initiatied the sign in to continue', | ||
| title: 'This verification link is invalid for this device', |
There was a problem hiding this comment.
Suggested change
| title: 'This verification link is invalid for this device', | |
| title: 'Verification link is invalid for this device', |
Optional - if we want to make it shorter
packages/localizations/src/en-US.ts
Outdated
| @@ -426,6 +431,11 @@ export const enUS: LocalizationResource = { | |||
| subtitleNewTab: 'Return to previous tab to continue', | |||
| title: 'Successfully verified email', | |||
| }, | |||
| clientMismatch: { | |||
| subtitle: | |||
| 'Open the verification link on the device and browser from which you initiatied the sign up to continue', | |||
There was a problem hiding this comment.
Suggested change
| 'Open the verification link on the device and browser from which you initiatied the sign up to continue', | |
| 'To continue, open the verification link on the device and browser from which you initiated the sign-up', |
packages/localizations/src/en-US.ts
Outdated
| clientMismatch: { | ||
| subtitle: | ||
| 'Open the verification link on the device and browser from which you initiatied the sign up to continue', | ||
| title: 'This verification link is invalid for this device', |
There was a problem hiding this comment.
Suggested change
| title: 'This verification link is invalid for this device', | |
| title: 'Verification link is invalid for this device', |
mzhong9723
force-pushed
the
mz/core-1979-email-link-status
branch
from
230d1dc
to
c63b451
Compare
LekoArts
approved these changes
May 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new
client_mismatchverification status for email link sign in and sign up flows. This new status will only be sent in as a query param if the corresponding setting is turned on in dashboard (future work).client_mismatch.mov
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change