Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(clerk-js): Reorganize cookies code and fix TokenUpdate event #3362

Merged
merged 9 commits into from
May 15, 2024
Merged

chore(clerk-js): Reorganize cookies code and fix TokenUpdate event #3362

merged 9 commits into from
May 15, 2024

Commits on May 15, 2024

  1. fix(shared): Change createCookieHandler#.set to return void

    @dimkl
    dimkl committed May 15, 2024
    Configuration menu
    Copy the full SHA
    6d3a8f7 View commit details
    Browse the repository at this point in the history

  2. chore(clerk-js): Centralize cookie code into single module

    @dimkl
    dimkl committed May 15, 2024
    Configuration menu
    Copy the full SHA
    fd9586a View commit details
    Browse the repository at this point in the history

  3. chore(clerk-js): Refactor SessionCookieService and auth/cookies handl… 

    …ers for consistency

There is also a fix for duplicate TokenUpdate event
and for cleaning the token in sign-out flow.
    @dimkl
    dimkl committed May 15, 2024
    Configuration menu
    Copy the full SHA
    6adb791 View commit details
    Browse the repository at this point in the history

  4. chore(clerk-js): Refactor Clerk.#environment modifier to protected to… 

    … use type assert
    @dimkl
    dimkl committed May 15, 2024
    Configuration menu
    Copy the full SHA
    b17a2c2 View commit details
    Browse the repository at this point in the history

  5. chore(repo): Add changeset

    @dimkl
    dimkl committed May 15, 2024
    Configuration menu
    Copy the full SHA
    c9d68ed View commit details
    Browse the repository at this point in the history

  6. chore(clerk-js): Rename SessionCookieService to AuthCookieService for… 

    … clarity
    @dimkl
    dimkl committed May 15, 2024
    Configuration menu
    Copy the full SHA
    fc997d8 View commit details
    Browse the repository at this point in the history

  7. chore(clerk-js): Add JSDoc for auth services and cookies

    @dimkl
    dimkl committed May 15, 2024
    Configuration menu
    Copy the full SHA
    a7150fa View commit details
    Browse the repository at this point in the history

  8. chore(clerk-js): Rename urlWithAuth to decorateUrlWithDevBrowserToken… 

    … method of auth service
    @dimkl
    dimkl committed May 15, 2024
    Configuration menu
    Copy the full SHA
    ed019b0 View commit details
    Browse the repository at this point in the history

  9. fix(clerk-js): Fix isSignedOut() to use both clientUat and clerk.user 

    This change was applied to keep the existing behaviour:
- clerk.user is used when clerk is loaded
- clientUat cookie is used when clerk is NOT loaded
    @dimkl
    dimkl committed May 15, 2024
    Configuration menu
    Copy the full SHA
    f731bfe View commit details
    Browse the repository at this point in the history